appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.66k stars 3.75k forks source link

chore: upgrade version of acorn and acron walk #37641

Closed ayushpahwa closed 10 hours ago

ayushpahwa commented 13 hours ago

Description

acorn and acorn walk did not have a fixed version, this pr fixes the versions to "acorn": "8.14.0", "acorn-walk": "8.3.4" respectively.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/test all

:mag: Cypress test results

[!TIP] šŸŸ¢ šŸŸ¢ šŸŸ¢ All cypress tests have passed! šŸŽ‰ šŸŽ‰ šŸŽ‰ Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11958829944 Commit: 518c41104561b6f0df8f546eb5a4e0b3e82c2676 Cypress dashboard. Tags: @tag.All Spec:


Thu, 21 Nov 2024 19:47:19 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Summary by CodeRabbit

coderabbitai[bot] commented 13 hours ago

Walkthrough

The pull request introduces updates to the package.json file of the @shared/ast package, specifically modifying the versions of two dependencies: acorn and acorn-walk. The former is updated from version ^8.8.0 to 8.14.0, while the latter is updated from ^8.2.0 to 8.3.4. Additionally, the canTranslateToUI and getMainAction functions in the index.ts file have been modified to enhance error handling and logic flow, improving the processing of AST nodes.

Changes

File Change Summary
app/client/packages/ast/package.json Updated acorn from ^8.8.0 to 8.14.0, updated acorn-walk from ^8.2.0 to 8.3.4.
app/client/packages/ast/src/actionCreator/index.ts Enhanced error handling in canTranslateToUI and updated logic in getMainAction. Function signatures modified.

Possibly related PRs

Suggested reviewers

Poem

In the land of code, where versions roam,
Two dependencies found a new home.
Acorn and walk, now fresh and bright,
Updated their paths, ready for flight.
With changes so small, yet oh so grand,
Together they stand, hand in hand! šŸŒ³āœØ


šŸ“œ Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
šŸ“„ Commits Reviewing files that changed from the base of the PR and between 81bc61706e196b11ac6a1e04da3d10d30de89b9a and 518c41104561b6f0df8f546eb5a4e0b3e82c2676.
šŸ“’ Files selected for processing (1) * `app/client/packages/ast/src/actionCreator/index.ts` (0 hunks)
šŸ’¤ Files with no reviewable changes (1) * app/client/packages/ast/src/actionCreator/index.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

ā¤ļø Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
šŸŖ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.