fix: fixing basePageId in settings url preview

brayn003 commented 9 hours ago

Description

Fixes issue with faulty pageId in the url preview in page settings

Fixes https://github.com/appsmithorg/appsmith/issues/37580

Automation

/ok-to-test tags="@tag.Git"

:mag: Cypress test results

[!CAUTION] 🔴 🔴 🔴 Some tests have failed. Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11970612362 Commit: 4307381ba6caa022e630b1d4d3f51494f52714c4 Cypress dashboard. Tags: @tag.Git Spec: The following are new failures, please fix them before merging the PR:

cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js
List of identified flaky tests.
Fri, 22 Nov 2024 11:10:08 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features
- Enhanced URL preview generation by utilizing the base page ID for more accurate path structures.
Bug Fixes
- Improved state management for page properties, ensuring accurate initialization and error handling when loading new pages.
Refactor
- Updated function parameters for URL generation to reflect changes in logic, maintaining overall functionality.

coderabbitai[bot] commented 9 hours ago

Walkthrough

The changes made in this pull request focus on updating the PageSettings component and the getUrlPreview function. The pathPreview calculation now utilizes basePageId instead of pageId, reflecting a new approach to URL generation. Additionally, state management within the PageSettings component has been refined to ensure proper initialization based on the incoming page prop. The error handling for page name changes has been preserved, while the overall control flow of the getUrlPreview function remains consistent.

Changes

File Path	Change Summary
`app/client/src/pages/Editor/AppSettingsPane/PageSettings.tsx`	Updated `pathPreview` calculation to use `basePageId`, refined state management and `useEffect` hooks.
`app/client/src/pages/Editor/AppSettingsPane/Utils.ts`	Changed parameter name from `pageId` to `basePageId` in `getUrlPreview` function and updated logic accordingly.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure URL parameters redirect to the correct page (37580)	✅
Default page selection when removing URL parameters (37580)	❌	The changes do not ensure default selection behavior.

Possibly related PRs

#36320: This PR modifies the PageSettings component, similar to the main PR, with changes to state management and page properties logic.

Suggested labels

Bug, Critical, High, Production, Needs Triaging, Git Product, ok-to-test

Suggested reviewers

ankitakinger
abhvsn

🌟 In the realm of code where logic flows,
A shift in paths, the baseId shows.
With states aligned and errors cleared,
The URL's journey is now revered.
Let pages connect, no more 404,
In this code adventure, let progress grow! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

brayn003 commented 9 hours ago

/build-deploy-preview

github-actions[bot] commented 9 hours ago

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11970621900. Workflow: On demand build Docker image and deploy preview. skip-tests: . env:. PR: 37652. recreate: .

github-actions[bot] commented 9 hours ago

Deploy-Preview-URL: https://ce-37652.dp.appsmith.com

appsmithorg / appsmith