appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.95k stars 3.66k forks source link

[Enhancement] Create spreadsheet should follow default formatting (ref comment for specs) #4104

Open YogeshJayaseelan opened 3 years ago

YogeshJayaseelan commented 3 years ago

Description

Release Environment - It is observed that when the numbers are passed in the row objects for insert scenario then the numbers are right aligned in the Google sheet

Expected Result Numbers should be left aligned in Googlesheet

Actual Result: Numbers are right aligned in the Googlesheet

Steps to reproduce the behaviour:

1.launch Appmsith app in the release environment 2.Expand API and Click on Googlesheet 3.Click on Add new Datasource and configure Email 4.Copy existing spreadsheet url, sheet name , column and values 5.click on 'New Query' 6.Choose the method as 'Insert' , 'Bulk Insert, 'Update' or 'Bulk update' 7.Pass the spreadsheet url which is noted at step 4 8.Pass the sheet name which is noted at step 4 9.Pass the following row object based on the column and values which are noted at step 4 [{ "FirstName":"Yogesh", "LastName":"J", "Email":"Yogikingston57it@gmail.com", "Phone":"9952563100" }, { "FirstName":"Yogeshh", "LastName":"JJ", "Email":"Yogikingston57itt@gmail.com", "Phone":"7550245695" }, { "FirstName":"Yogeshhh", "LastName":"JJJ", "Email":"Yogikingston57ittt@gmail.com", "Phone":"7550245123" }, { "FirstName":"Yogeshhh", "LastName":"JJJ", "Email":"Yogikingston57ittt@gmail.com", "Phone":"9952563200" }] 10.Click on Run and verify the success message

  1. Open the Google sheet and observe the values

Important Details

nidhi-nair commented 3 years ago

Modifying the scope for this a little bit. The behaviour that is seen is that during inserts and updates, the operations respect sheet formatting. But during create sheet, there is no formatting present for reference, and hence everything is treated as a string.

Will need to check if there is any default formatting that can be relied on. Basically it's create spreadsheet that needs to be updated here.