[Bug]In Radio button widget->In property pane->if the options section(label or value) is kept empty the required error message should be displayed

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.

https://www.appsmith.com

Apache License 2.0

33.95k stars 3.66k forks source link

[Bug]In Radio button widget->In property pane->if the options section(label or value) is kept empty the required error message should be displayed #4653

Open RakshaKShetty opened 3 years ago

RakshaKShetty commented 3 years ago

Description

[What happened] In Radio button widget->In property pane->if the options section(label or value) is kept empty the required error message should be displayed

Steps to reproduce the behaviour:

Go to the application
Drag and drop the radio button widget
in the property pane
Under Option Section
Keep the label and value empty
verify the display

Expected Result: When the user kept the label and value section blank the error message should be displayed

Actual Result: Now when the label and value placeholder is kept blank the placeholder is displayed with red outline even it display red outline when the user is editing which wont make any difference

Important Details

Version: Cloud
OS: Windows
Browser chrome

knockknockyoo commented 3 years ago

@Nikhil-Nandagopal If no one is working on this, can you assign it for me?

Nikhil-Nandagopal commented 3 years ago

@Devedunkey go for it! It's all yours. @somangshu will help you contribute 🙂

somangshu commented 3 years ago

👋 @Devedunkey, Thanks for showing interest. I see you have contributed to the Appsmith repository before. In that case, I believe you already have the apt Knowledge to proceed with this.

Anyways here are some brief steps.

Appsmith client-side local setup: https://github.com/appsmithorg/appsmith/blob/release/contributions/ClientSetup.md
Our development workflow: fix/features (deployable features) -> release (staging environments) -> master (production environment)
All active contribution should be made on the release branch, hence kindly create your sub-version branch from release.
In case you have any challenges, drop a comment here or get in touch with us on our discord server.

Looking forward to having another contribution from you 😊 🚀

riodeuno commented 3 years ago

@momcilo-appsmith We need to update the designs for this control. If we have that, this can be easy to fix.

momcilo-appsmith commented 2 years ago

@riodeuno Vasanth will be taking this one.

vasanthappsmith commented 2 years ago

@somangshu Here is the updated design for this issue.

LINK

somangshu commented 2 years ago

@momcilo-appsmith @vasanth-appsmith there are more challenges with this control, Ex right now the name and label are visible, So somebody who open this property pane for a new widget for the fist time, They would not know what is for what.

Another problem is technical, i.e. the interoperability between the JS mode and the UI mode is not consistent and results in data loss, For now we are planning to get rid of this control everywhere.

cc @riodeuno

somangshu commented 2 years ago

@somangshu Here is the updated design for this issue.

LINK

Quick note @vasanth-appsmith, please update the main description with the design link so that it doesnt get missed later

dilippitchika commented 2 years ago

Reach: 20 Impact: Low