[Bug]In Firestore for "Get Documents in Collection" method the "where condition" doesn't work for Number, Null, Boolean, Array of Numbers, Geolocation

[RakshaKShetty]

Description In Firestore for "Get Documents in Collection" method the "where condition" doesn't work for Number, Null, Boolean, Array of Numbers, Geolocation

[What happened]

https://loom.com/share/0665bef56ad14ceb9a3b00bbeaf8594a

Steps to reproduce the behaviour:

1.Add the new data source Firestore 2.Select method as "get documents in collection" 3.Add document/collection path

4. under where the condition
5. add the path and the value should be a "number" data type
6. then the output will be displayed as empty array

Important Details

• Version: [Cloud ]
• OS: [MacOSX]
• Browser [ safari]
• Environment [release frozen]

[ajinkyakulkarni]

@trishaanand Hey team! Can you please add your planning poker estimates with ZenHub

[ajinkyakulkarni]

@trishaanand @ohansFavour Hey team! Can you please add your planning poker estimates with ZenHub

[trishaanand]

We can infer the data types and parse them accordingly before actually executing the query, but there is no way for the user to override these data types inferred.

[areyabhishek]

A user reported this bug on Intercom again today. See message below: "also, i had reported this bug on discord like 3 months ago, where if you try to make firestore query with ==, <=, >= and a number, it just returns empty array where it should return proper docs. I just checked and it's still not fixed. It basically makes firestore query unusable if you want to use a number in the query."

@trishaanand @ohansFavour I can see that this issue was assigned.

[sumitsum]

Removing the following special data types from the scope since we would need to have few design related discussions before we can proceed with implemention: (1) GeoPoint (2) Reference (3) Timesamp. We are tracking the support for special data types here: https://github.com/appsmithorg/appsmith/issues/3741

[leotom2000]

Number - works ==, <, <=, >, >=

IN - Works []

Boolean - Works "=="

Array - Not working

• Backend is implemented , there "ARRAY_CONTAINS_ANY" "ARRAY_CONTAINS"
• Frontend not implemented, Need "contains any" "contains" Need to create a FE issue

Geolocation - Not Working

• Not implemented Need to create FE and BE issue

[RakshaKShetty]

Still facing the issue

[sumitsum]

@leotom2000 can you please check out the video Raksha has shared ?

[leotom2000]

@ajinkyakulkarni @rohan-arthur @sumitsum We need a functional clarification regarding this reopened issue.

Firestore offers two operators "array-contains" and "array-contains-any" The QA has tested it like a string, even in future end-users may do the same. The reason is, we are mentioning in Where condition as "Contains"

Here the implementation is correct, but the way the general user may search is unguided. The expectation here is the user should search in an array.

(1) Should we change the dropdown to "Array Contains", "Array Contains Any" in the dropdown. The draw back is the field will be wider and inconsistent,

(2) Should we retain this and throw a error message informing the user to search in an array.

Here is the docs related to Query operator https://firebase.google.com/docs/firestore/query-data/queries

[leotom2000]

Closing this issue as there are no changes in the implementation. A UI change is required to resolve the misunderstanding and that will be addressed by another issue below https://github.com/appsmithorg/appsmith/issues/13880