appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.3k stars 3.71k forks source link

[Bug]-[1000]:Preserve the scroll position when coming back to the parent's property pane #6164

Open vivekverma2312 opened 3 years ago

vivekverma2312 commented 3 years ago

Steps to reproduce the behaviour:

  1. Drag and drop table widget on canvas
  2. Open property pane
  3. Click on column properties
  4. Now click on back icon
  5. Observe that user scroll to top and scroll is not maintained

LOOM DEMO

somangshu commented 3 years ago

@riodeuno I too feel this should be the intended behaviour, Can you think of a way to achieve this on a global level?

riodeuno commented 3 years ago

@somangshu It is clear that the panels open only on click of a property control which enables such a behaviour. In this case the primaryColumnsControl. When we close or go back in a panel we can make sure to scroll to the concerned property control. We're implementing something similar in the undo/redo feature.

Having said that, I would consider the project in which we deal with the re-organization and design of the property pane. Once this has been implemented, we can circle back to this issue and ascertain the legitimacy of this issue.

dilippitchika commented 2 years ago

Small UX issue but impacts almost all table/button group/json form app users

Stats

Stat Values
Reach 1000
Effort (months) 0.5
dilippitchika commented 2 years ago

@rohitagarwal88 can you please triage this issue for ui-builders team to pick it up?

rohitagarwal88 commented 2 years ago

@rahulramesha : This problem should solve when we context switching?