Open somangshu opened 3 years ago
When I add many APIs and Queries, long name is better for readability.
For example, when I want to create query that disable all setting about integration, I can create query name like disable_all_integration_settings_for_user
(41 characters).
IMO, 256 characters would be fine limits for many use cases.
@toughrogrammer thanks for your comment. Although this is a simpler fix, we will need to do a proof of concept to see how this change would affect UX across the product. The same limit exists for other names across the product. We will need to see if we allow longer names, how will it be shown in autocomplete, tooltips, etc.
We will get back to you about this issue.
I concur about the "need" for longer data source names. A small example of how I organize data sources and JSObjects to show you why I find 30 chars quite limiting:
I use Google spreadsheets and give the data sources manipulating the same resource the same "base name", but with a "REST like" method appended appended. Example: weeklyCustomerSales_GET
, weeklyCustomerSales_CLEAR
and weeklyCustomerSales_POST
. This has the nice side effect getting the sources nicely grouped in the Appsmith editor.
At first I used to write the JS for the Row objects field of the data source directly in the field, but for complex cases with a number of queries associated with the same spreadsheet I now create a JSObject with the same name as the queries' "base name", in the above example that would beweeklyCustomerSales
, and then the Row object's code is only a call to the similarly named function in the JSObject: {{weeklyCustomerSales.clear()}}
or {{weeklyCustomerSales.post()}}
. Again, this nicely organizes all JS relevant to one spreadsheet in one place.
But when setting up the code in this way the "effective character limit" becomes only 24 characters for the JSObject as I want append the "method" to the data sources and all of it needs to fit in 30 chars (given the "methods" above; using _DELETE
or _INSERT
would result in only 23 left). Thus a base name like weeklySalesPerCustomerTotal
is "too long" which in my case is the appropriate name for what the spreadsheet data represents. :cry:
As always, take this as (hopefully) constructive criticism, and not whining... Appsmith is great!
Hi, I'm a new contributor to this but I'd like to learn how to contribute to Appsmith for my university assignment. I will read through the contributing guide carefully, could you please assign this issue to me so that I can give it a try on solving it?
Many thanks!
Also, can you give me some hints on where I can get started if possible?
Workshop4 GroupF(just a reminder for my assignment group)
Hi Someone could suggest me what are the best possible approaches to set the desired limit for APIs / Queries / Datasources..
@toughrogrammer thanks for your comment. Although this is a simpler fix, we will need to do a proof of concept to see how this change would affect UX across the product. The same limit exists for other names across the product. We will need to see if we allow longer names, how will it be shown in autocomplete, tooltips, etc.
We will get back to you about this issue.
@ajinkyakulkarni Hi just wanted to know in which file we need to do such changes to support longer queries and api names.
I am a student at Florida International University (FIU), currently working on an assignment that involves contributing to an open-source project. If the issue still open, could you please assign it to me?
Hey i am new comer to open source contribution, looking forward to fix this issue, could you please assign it to me
@akhilk2802 excited for your contributions! Would you please pick one from this list: https://github.com/appsmithorg/appsmith/issues?q=is%3Aopen+is%3Aissue+label%3A%22Inviting+Contribution%22
Look out for comments, to make sure that someone else isn't already working on an issue
Okay sure, Thanks
Summary
As an Appsmith Developer, I should be allowed to enter Query / API names which are more that 30 chars long.
Motivation
In case there are many APIs / Queries its easier to remember or create more names not worrying about the uniqueness of it