search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.82k stars 3.64k forks source link

[Bug]The user cant bind data in the input widget if the column name are numeric #6671

Closed RakshaKShetty closed 2 years ago

RakshaKShetty commented 3 years ago

Description

[What happened]The user cant bind data in the input widget if the column name are numeric

Steps to reproduce the behavior:

1.Generate a page using google sheet 2.Select a sheet that has a numeric value as its column name 3.now very the display of the autogenerated template image If the column names are numeric then that value is not displayed in the autosuggest image

Important Details

somangshu commented 3 years ago

Good Find @RakshaKShetty. The issue is not with the table widget or google sheets plugin. It's to do with evaluations. Happens if you even update a widget name with an integer and try referencing it I am guessing this is a limitation. @hetunandu please shed some light on this. Is this a deliberate move? Is this hard to fix?

Nikhil-Nandagopal commented 3 years ago

@somangshu I would actually argue that it is with the table widget because 24 is an invalid variable name in JS (cannot start with numbers). So the table needs to sanitize it (maybe add an underscore?)

sbalaji1192 commented 2 years ago

@techbhavin I had removed the migrations you wrote for this issue, in order to resolve a critical issue where we were resetting the custom column name - https://github.com/appsmithorg/appsmith/pull/10218. so reopening this issue to fix the migration function to rewrite numerical column names for existing application. CC: @somangshu

somangshu commented 2 years ago

We should resolve this quickly, Please gather the information required here @techbhavin and implement this soon