[Feature] Show contextual search menu in the debugger

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.

https://www.appsmith.com

Apache License 2.0

32.3k stars 3.5k forks source link

[Feature] Show contextual search menu in the debugger #7149

Open akash-codemonk opened 2 years ago

akash-codemonk commented 2 years ago

Summary

https://www.figma.com/file/EdC0j0XwxyC9Flqzxyoxuf/Debugger?node-id=2677%3A3923

Show contextual(based on error type) search menu in the debugger

VALIDATION - Copy / Search Docs / Snippet/ Ask Intercom PARSE - Copy / Search Google/Snippet LINT - Copy / Search Google/Snippet PLUGIN_EXECUTION DATASOURCE_CONFIGURATION_ERROR - Copy / Search Google / Ask Intercom PLUGIN_ERROR - Copy / Search Google / Ask Intercom CONNECTIVITY_ERROR - Copy / Search Docs ACTION_CONFIGURATION_ERROR - Copy / Search Docs / Ask Intercom

ramsaptami commented 2 years ago

Below scenarios currently display all 5 options of the contextual menu (CM) since the errors are not associated with the above mentioned 7 categories of CM. Please add these to the relevant categories so CM can be more appropriately filtered.

[ ] Create a new API for Google sheets and click Run without entering any values. Response is 500
[ ] Enter an incorrect sheet name on Google sheets query page. Response is 400
[ ] Hit Run after entering only URL without resource/queryparam for API. Response is 404
[ ] Run a query for unauthorized GSheet data source, returns a 400 (shouldn't this be a 401?) and needs CM category
[ ] Resource not found 404. Repro by passing incorrect GSheets URL
[ ] For incorrect API URL response
[ ] API Internal server error
[ ] Revoke access to Google sheets and observe a 403 for any existing query

akash-codemonk commented 2 years ago

Below scenarios currently display all 5 options of the contextual menu (CM) since the errors are not associated with the above mentioned 7 categories of CM. Please add these to the relevant categories so CM can be more appropriately filtered.

[ ] Create a new API for Google sheets and click Run without entering any values. Response is 500

[ ] Enter an incorrect sheet name on Google sheets query page. Response is 400

[ ] Hit Run after entering only URL without resource/queryparam for API. Response is 404

@AnaghHegde Currently we are considering these errors on the frontend.

DATASOURCE_CONFIGURATION_ERROR - Copy / Search Google / Ask Intercom PLUGIN_ERROR - Copy / Search Google / Ask Intercom CONNECTIVITY_ERROR - Copy / Search Docs ACTION_CONFIGURATION_ERROR - Copy / Search Docs / Ask Intercom

But for the cases mentioned above by saptami we seem to have some other type.

AnaghHegde commented 2 years ago

Below scenarios currently display all 5 options of the contextual menu (CM) since the errors are not associated with the above mentioned 7 categories of CM. Please add these to the relevant categories so CM can be more appropriately filtered.

[ ] Create a new API for Google sheets and click Run without entering any values. Response is 500

[ ] Enter an incorrect sheet name on Google sheets query page. Response is 400

[ ] Hit Run after entering only URL without resource/queryparam for API. Response is 404

@akash-codemonk @ramsaptami

This needs a change on backend and i will make this change
Incorrect urls are part of PLUGIN_ERROR i will check this
This does not fall into any of this. I think it was kept like by intentionally, i will check with Nikhil on this.

ramsaptami commented 2 years ago

@AnaghHegde @akash-codemonk I'll keep updating the original comment of mine for new scenarios that I come across, so please check for updates there

bharath31 commented 1 year ago

Seems to be a stale issue. Closing this one out.