search

appsmonkey / air.nodemcu.full

CityOS Air Device Code
Apache License 2.0
4 stars 9 forks source link

ArduinoJson library outdated / causing compilation error #5

Open jessesteinen opened 3 years ago

jessesteinen commented 3 years ago

When compiling the code, I'm getting:

.pio/libdeps/nodemcuv2/ArduinoJson/src/ArduinoJson/MsgPack/MsgPackSerializer.hpp:28:7: error: attributes are not allowed on a function-definition
     28 |       ARDUINOJSON_NO_SANITIZE("float-cast-overflow") {
        |       ^~~~~~~~~~~~~~~~~~~~~~~

This is due to a bug in ArduinoJson 6.10.0, which was fixed 2 years (!) ago, in 6.10.1 I updated platformio.ini to use the most recent 6.18.0 version which resolves this. I will submit a PR for this later.

jessesteinen commented 3 years ago

Created PR #7 for this.