search

appsody / appsody-operator

An Operator for deploying Appsody based applications to Kubernetes. This repo will be archived soon.
Apache License 2.0
18 stars 15 forks source link

appsody-operator does not watch child ksvc for re-create / reconcile #184

Closed dacleyra closed 4 years ago

dacleyra commented 4 years ago

Bug Report

What did you do?

Create an appsodyapplication and enable knative service spec.createKnativeService: true Observe there is a ksvc for the appsodyapplication oc get ksvc Delete the ksvc oc delete ksvc name

What did you expect to see?

Expect that the ksvc would be recreated by watch / reconcile

What did you see instead?

crickets

however, deleting the appsody-operator causes a re-reconcile which will re-create the ksvc

Environment

Client Version: v4.3.0 Server Version: 4.2.0 Kubernetes Version: v1.14.6+2e5ed54

Possible solution

Watch for owned ksvc object, example https://github.com/kabanero-io/kabanero-operator/blob/master/pkg/controller/collection/collection_controller.go#L80

Additional context

Add any other context about the problem here.

arturdzm commented 4 years ago

This is functionality that operator is lacking in general right now, regardless of use of Knative.

arturdzm commented 4 years ago

Should be fixed in next release