search

appsody / appsody

Appsody command line tool. This repo will be archived soon.
https://appsody.dev
170 stars 46 forks source link

Appsody on K8S should not warn about missing docker pre-req #458

Closed chilanti closed 4 years ago

chilanti commented 4 years ago

Is your feature request related to a problem? Please describe. Appsody on K8S should not check whether docker is installed and running, and should avoid warning the user about the missing pre-req.

Describe the solution you'd like Suppress checking the docker pre-req when on K8S.

sympatheticmoose commented 4 years ago

@chilanti when you get a chance can you update this issue with a bit more information about why the check is not required on K8s, as this is a record of the change.

chilanti commented 4 years ago

This is a nice to have. Appsody checks pre-reqs (aka whether docker is installed), but it shouldn't be doing it when it runs on K8S since docker isn't even used. Suppressing the warning should be a simple change.

chilanti commented 4 years ago

@neeraj-laad - I can take care of this, or someone in Hursley could give it a try. I think there are two things here: 1) If someone specifies the --buildah flag, the pre-req's check should be turned off 2) If the env var APPSODY_K8S_EXPERIMENTAL is TRUE - same thing. Looking at the code path, I think that checking the flag is probably all there is to it, because the env var causes the flag to be set.