search

appsody / controller

Appsody controller running in the development container. This repo will be archived soon.
https://appsody.dev
Apache License 2.0
2 stars 12 forks source link

Improve process termination when changes are detected #16

Closed kewegner closed 4 years ago

kewegner commented 5 years ago

Many stacks have ON_CHANGE commands that end the process by themselves and there is no need to kill them.

Currently the controller tries to kill them in this case, and prints out warning messages which say the kill failed and there is no such process

Outcome desired: Either:

  1. suppress the above messages

or

*2. Use a similar technique that we use to determine server failures and restarts in the on change events where we send a benign signal to determine if the process is alive. Then we could avoid unnecessary kill actions.

neeraj-laad commented 5 years ago

@kewegner Would like to get your thoughts on this issue.

kewegner commented 5 years ago

This will be dealt with by the fix I'm making for https://github.com/appsody/appsody/issues/118