search

appsody / controller

Appsody controller running in the development container. This repo will be archived soon.
https://appsody.dev
Apache License 2.0
2 stars 12 forks source link

Support custom APPSODY_MOUNT separator #31

Open gireeshpunathil opened 5 years ago

gireeshpunathil commented 5 years ago

Is your feature request related to a problem? Please describe. Please refer to https://github.com/appsody/appsody/issues/31

Describe the solution you'd like Please refer to https://github.com/appsody/appsody/issues/31

Describe alternatives you've considered Please refer to https://github.com/appsody/appsody/issues/31

Additional context https://github.com/appsody/appsody/pull/338 is raised in appsody, a similar change in controller in this repo would compliment it

gireeshpunathil commented 5 years ago

cc @kewegner

kylegc commented 5 years ago

@gireeshpunathil why would the controller need this? The controller does not run docker commands.

kewegner commented 5 years ago

The controller uses the APPSODY_MOUNTS environment variable in the case there are no APPSODY_WATCH_DIRS.

If we change the value of APPSODY_MOUNTS to have something other than ";" as a separator, the logic in the controller would have to change, because it splits on ";". See line 269 of main.go.

kylegc commented 5 years ago

Ok, so to clarify, adopting the docker --mount syntax to allow colons does NOT need controller changes.

However if as a result we change the APPSODY_MOUNTS separator, then yes the controller needs to support this.

kewegner commented 4 years ago

When this issue is done, we would also want to consider the separator for the APPSODY_WATCH_DIRs and the APPSODY_WATCH_IGNOREDIRS (PATHS). Since those are in a list using ';' as the separator.

kewegner commented 4 years ago

We should address https://github.com/appsody/controller/issues/31 at the same time. Also the changes we made for single mount testing might be affected.

kewegner commented 4 years ago

I have started to code this up and will work with @rykal-nate prior to Friday.

neeraj-laad commented 4 years ago

We expect more changes in this area and would prefer to get a clear design agreed across various components - stacks, cli, controller etc. Other priorities have not allowed us to focus on this use case as much.

I've closed 2 PRs related to this, but once we have more clarity on how we want to enable this use case, we can re-open this PR again.