Closed Kamran64 closed 4 years ago
This looks good to me. I've tested the remote debug with IntelliJ and with live code reload and it seems to work fine.
I haven't yet tried it with VSCode, but can install it if you need another pair of eyes on it.
Thanks! No need to install VSCode, @Kamran64 and I have already checked it works :)
Checklist:
[x] Read the Code of Conduct and Contributing Guidelines.
[x] Followed the commit message guidelines.
[x] Stack adheres to Appsody stack structure.
Modifying an existing stack:
stack.yaml
Adds
launch.json
files to the templates sinceappsody debug
seems to be supported (also removes issue in the README). Also adds theAPPSODY_DEBUG_PORT
environment variable to theDockerfile-stack
. This provides "documentation" over which port will be used for debugging and will be used by external projects such as Codewind who need this information specified.