appsody / stacks

Appsody application stacks. This repo will be archived soon.
https://appsody.dev
Apache License 2.0
89 stars 121 forks source link

Quarkus: Add launch.json to templates and add APPSODY_DEBUG_PORT #824

Closed Kamran64 closed 4 years ago

Kamran64 commented 4 years ago

Checklist:

Modifying an existing stack:

Adds launch.json files to the templates since appsody debug seems to be supported (also removes issue in the README). Also adds the APPSODY_DEBUG_PORT environment variable to the Dockerfile-stack. This provides "documentation" over which port will be used for debugging and will be used by external projects such as Codewind who need this information specified.

paulrobinson commented 4 years ago

This looks good to me. I've tested the remote debug with IntelliJ and with live code reload and it seems to work fine.

I haven't yet tried it with VSCode, but can install it if you need another pair of eyes on it.

skoh7645 commented 4 years ago

Thanks! No need to install VSCode, @Kamran64 and I have already checked it works :)