Closed djones6 closed 4 years ago
@gireeshpunathil Do you think this can be merged?
@gireeshpunathil Do you think this can be merged?
Yes. @neeraj-laad - for your review
(Ironically, I am a maintainer of the stack, but not a maintainer of this repo)
@gireeshpunathil - Usually we wait to see an approval from the stack maintainer before merging.
@djones6 - Please could you bump the stack version in the stack.yaml
and then we can get this merged. Thanks!
@gireeshpunathil - Usually we wait to see an approval from the stack maintainer before looking.
can you pls document this? It is neither evident here, nor an established practice in OSS
@gireeshpunathil I've added you as a stack maintainers group.
Also the review for maintainers is documents in our contribution process.
@djones6 please can you bump the stack version so we can merge this?
This PR illustrates how to avoid a hang when running the stack tests where the application makes connections to external services.
Checklist:
[x] Read the Code of Conduct and Contributing Guidelines.
[x] Followed the commit message guidelines.
[x] Stack adheres to Appsody stack structure.
Modifying an existing stack:
stack.yaml
I have added a callback on the HTTP server
close
event, to disconnect the Kafka producer and consumer. This allows the process to terminate normally.Related Issues:
Resolves #831