add splash page for quarkus kafka project

appsody / stacks

Appsody application stacks. This repo will be archived soon.

https://appsody.dev

Apache License 2.0

89 stars 121 forks source link

add splash page for quarkus kafka project #843

Closed josiemundi closed 4 years ago

josiemundi commented 4 years ago

Checklist:

[x] Read the Code of Conduct and Contributing Guidelines.
[x] Followed the commit message guidelines.
[x] Stack adheres to Appsody stack structure.

Modifying an existing stack:

[x] Updated the stack version in stack.yaml

I have added a splash page for the root of the starter application in the Quarkus stack for Kafka template. Previously, there was not one and this was causing issues as outlined in the one at the following link:

Related Issues:

CLAassistant commented 4 years ago

All committers have signed the CLA.

neeraj-laad commented 4 years ago

@josiemundi Thanks for your contribution! Please can you review and sign our CLA before we look at this PR.

paulrobinson commented 4 years ago

@ianpartridge do you want to review this too? I see you have an interest in the index.html file and discuss it in https://github.com/quarkusio/quarkus-quickstarts/issues/617

ianpartridge commented 4 years ago

Thanks Paul. I'm happy with this - our need was for this template to have something at the root so when a user deploys it on OCP and clicks "Open URL" they don't see an error. Adding this static page absolutely fulfils that (and moves this closer in sync with the upstream quickstart too 👍 )