appsody / website

Appsody website and documentation. This repo will be archived soon.
https://appsody.dev
Apache License 2.0
13 stars 29 forks source link

Add docs for specifying application-name #524

Closed helenmasters closed 4 years ago

helenmasters commented 4 years ago

Checklist

Description

See associated issue #522

Related Issues

Fixes #522

helenmasters commented 4 years ago

Looks good - I would just add that the value is added to app.kubernetes.io/part-of label in the deployment resource. Maybe this should be added in the label doc that needs to be created.

Thanks for the review. I don't think we should add this to this doc but rather should link out to the label doc when we create it.