appsquickly / typhoon-example

An example application built with Typhoon dependency injection framework.
Apache License 2.0
251 stars 59 forks source link

TyphoonPropertyPlaceholderConfigurer not found in PFWeatherClientTests.m #17

Closed davidbernard closed 10 years ago

davidbernard commented 10 years ago

At 9fd74df1d3

Xcode reports: Use of undeclared identifier 'TyphoonPropertyPlaceholderConfigurer'

[factory attachPostProcessor:[TyphoonPropertyPlaceholderConfigurer configurerWithResource:configurationProperties]];
jasperblues commented 10 years ago

Apologies. We need to update the project to build against the latest Typhoon. . there are minor changes to class/method names. . . I won't be able to do this for a few hours, but definitely in the next 24.

Meanwhile, the Pods are checked in. So if you take a clean checkout, and open the workspace, you should be able to build right away. Does it not?

davidbernard commented 10 years ago

The application builds and runs but not the tests. In evaluating typhoon it is the test that interest me. I'm sure it is a simple fix.

jasperblues commented 10 years ago

OK, fixing now. . .

Meanwhile Typhoon itself (not this example) has tests executed after each commit:

As well as build failure if test coverage falls below 88% . . .

jasperblues commented 10 years ago

I have fixed the tests. But please stand by, there's a few other small changes to modernize the app, and reflect current best practices with Typhoon.

jasperblues commented 10 years ago

OK, also updated the example to:

jasperblues commented 10 years ago

And fixed project settings so that it runs on device.

Closing. . . thanks for reporting. Let us know if any other issues.