Fresh setup of application is not working

appsquickly / typhoon-example

An example application built with Typhoon dependency injection framework.

Apache License 2.0

251 stars 59 forks source link

Fresh setup of application is not working #22

Closed lambovg closed 9 years ago

lambovg commented 9 years ago

Invalid key exception if we not using v2 in endpoint.

From new api temp is missing in some places and this cause app to crash.

lambovg commented 9 years ago

I've created a new key for the api - most probably new keys are working only with v2 api version.

jasperblues commented 9 years ago

Thanks so much @gogoluxecs

If you're in the mood it would be awesome if you could also do the Swift example: https://github.com/typhoon-framework/Typhoon-Swift-Example

jasperblues commented 9 years ago

Related SO question: http://stackoverflow.com/a/26643526/404201

lambovg commented 9 years ago

Yeah I can do it during the weekend. btw - it seems that there're changes in the api and min/max temp can't be retrieved for the future days. This patch was just to have working test solution.

If you want - you can create task and assign to me for that - to update to as in screenshots.

jasperblues commented 9 years ago

Ah, it sounds as though they'd like folks to purchase the paid version of the API. Sounds, good be we really need something simple and free for Typhoon.

Perhaps we can switch to another API. First result in Google: http://openweathermap.org/api

Would be a shame if we have to drop the high/low temps for the forecast.

lambovg commented 9 years ago

yeah - we can do it. To me is ok to have it working in that way and in a new branch to make a change for the new api.

What do you think?

jasperblues commented 9 years ago

@gogoluxecs That sounds absolutely fantastic. Much appreciated! Would you like push access?

lambovg commented 9 years ago

@jasperblues LOL - I can't say NO to that. Cool!

jasperblues commented 9 years ago

Done. Simple rules:

Simple bug fixes and clean up - go ahead and push.
New features : Raise an issue in Github and get consensus (as we've done here). When done mark "Ready for Review" (this applies especially to Typhoon Core).
Any unstable changes to be done on a branch, merge when done.

Also meet @sebastianwr , who's also recently joined us. He's been looking at extending the sample apps to feature some other Typhoon features - particularly UIStoryboard integration.

sebastianwr commented 9 years ago

Hi @gogoluxecs

@jasperblues If I ever manage to get my first super simple app working with storyboards, I am happy to re-use this for a full demonstration. ;)

jasperblues commented 9 years ago

@sebastianwr You're doing great. Swift is a new frontier.

lambovg commented 9 years ago

Hi @sebastianwr

@jasperblues - I understood the rules

jasperblues commented 9 years ago

@sebastianwr @gogoluxecs As contributors you also get to be featured on the Typhoon website, www.typhoonframework.org . . if that's of interest please send a picture and biography to info@typhoonframework.org

lambovg commented 9 years ago

@sebastianwr - nice! I will send picture and bio for sure.