Global namespace is not applied properly for TyphoonConfigPostProcessors

appsquickly / typhoon

Powerful dependency injection for Objective-C ✨✨ (https://PILGRIM.PH is the pure Swift successor to Typhoon!!)✨✨

https://pilgrim.ph

Apache License 2.0

2.7k stars 269 forks source link

Global namespace is not applied properly for TyphoonConfigPostProcessors #474

Closed etolstoy closed 7 years ago

etolstoy commented 8 years ago

TyphoonAssemblyDefinitionBuilder, line 90 - we should check if the namespace is already registered. Current implementation proceeds a bug for TyphoonConfigPostProcessors registered using + (instancetype)configDefinitionWithName:(NSString *)fileName - they should belong to a global namespace.