Fixed bundle resource in setAppDelegate swizzling via Carthage

appsquickly / typhoon

Powerful dependency injection for Objective-C ✨✨ (https://PILGRIM.PH is the pure Swift successor to Typhoon!!)✨✨

https://pilgrim.ph

Apache License 2.0

2.7k stars 269 forks source link

Fixed bundle resource in setAppDelegate swizzling via Carthage #519

Closed vasilenkoigor closed 8 years ago

vasilenkoigor commented 8 years ago

PR solving #508 issue.

As a result, + (void)swizzleSetDelegateMethodOnApplicationClass was fixed by changing bundle class.

@alexgarbarev need write tests for this case?

alexgarbarev commented 8 years ago

@vasilenkoigor This looks good to me. I don't think we can test via unit tests carthage integration here. Have you tested carthage installation manually?

vasilenkoigor commented 8 years ago

@alexgarbarev yep, I'm tested carthage installation manually today. Works good.

alexgarbarev commented 8 years ago

👍 Good. Thanks @vasilenkoigor