appsquickly / typhoon

Powerful dependency injection for Objective-C ✨✨ (https://PILGRIM.PH is the pure Swift successor to Typhoon!!)✨✨
https://pilgrim.ph
Apache License 2.0
2.7k stars 270 forks source link

Always calls setDelegate: original implementation. #574

Closed XiangtianDai closed 6 years ago

XiangtianDai commented 6 years ago

This fixes an issue that setting application delegate with nil or for the second time has no effect.

codecov-io commented 6 years ago

Codecov Report

Merging #574 into master will decrease coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
- Coverage   87.03%   87.02%   -0.02%     
==========================================
  Files         297      297              
  Lines        8035     8036       +1     
  Branches      542      542              
==========================================
  Hits         6993     6993              
- Misses        764      765       +1     
  Partials      278      278
Impacted Files Coverage Δ
Source/Configuration/Startup/TyphoonStartup.m 67.18% <0%> (-1.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe12546...11c90b5. Read the comment docs.

alexgarbarev commented 6 years ago

Thanks @XiangtianDai. This looks like a right thing!