Closed daria-kopaliani closed 6 years ago
Merging #582 into master will increase coverage by
3.63%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 87.02% 90.65% +3.63%
==========================================
Files 297 185 -112
Lines 8036 6162 -1874
Branches 542 383 -159
==========================================
- Hits 6993 5586 -1407
+ Misses 765 572 -193
+ Partials 278 4 -274
Impacted Files | Coverage Δ | |
---|---|---|
Source/Definition/Method/TyphoonMethod.m | 69.44% <100%> (-5.03%) |
:arrow_down: |
Source/Factory/Internal/TyphoonRuntimeArguments.m | 89.7% <100%> (+9.7%) |
:arrow_up: |
Tests/Configuration/TyphoonConfigAppDelegateMock.m | 0% <0%> (-100%) |
:arrow_down: |
Tests/Model/Fort.m | 0% <0%> (-100%) |
:arrow_down: |
Source/Factory/Pool/TyphoonWeakComponentsPool.m | 77.77% <0%> (-17.88%) |
:arrow_down: |
...version/Converters/TyphoonPrimitiveTypeConverter.m | 75% <0%> (-15.15%) |
:arrow_down: |
...tion/Injections/TyphoonInjectionByObjectInstance.m | 81.81% <0%> (-12.3%) |
:arrow_down: |
...tion/Injection Aware/ComponentFactoryAwareObject.m | 20% <0%> (-8.58%) |
:arrow_down: |
...on/Injections/TyphoonInjectionByComponentFactory.m | 20% <0%> (-8.58%) |
:arrow_down: |
Tests/Definition/TyphoonDefinition+Tests.m | 91.66% <0%> (-8.34%) |
:arrow_down: |
... and 286 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3a04dd7...1906481. Read the comment docs.
This PR is now outdated and needs merge. I'll close it for now. Any idea on how to create unit test for this bug?
Thanks for this PR, but please check my answer here: https://github.com/appsquickly/Typhoon/issues/581