Closed tarastomchuk closed 4 years ago
Same issue I am also facing with tab bar
I'm using this workaround
// Somehow the custom modal presentation transitioning uses the tab bar controller so this needs to be done as extension of the Tab Bar Controller.
extension UITabBarController: CardsViewController {
public var transitionDelegate: CardTransitioningDelegate? {
// Not needed for now
get { nil }
set {}
}
}
CardTransitioningDelegate is not there demo project,Could you please tell me where you are using
Can you do a demo that reproduces this issue? I seems to work fine for me.
Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value: file /Users/Project/Pods/appstore-card-transition/AppstoreTransition/AppstoreTransition/PresentCardAnimator.swift, line 90
app is crashing in PresentCardanimator line number 90 while using tabbar . I am using xcode11.3.1 and swift 5.0
I cannot reproduce this. Can you provide a demo project?
Same issue. UITabbarController -> UINavigationControler -> FromViewController(root) -> ToViewController Could not cast value of type 'UITabBarController' to 'AppstoreTransition.CardsViewController'.
Guys please provide a demo project if you want this fixed, I cannot produce it.
My demo project. https://github.com/quyentrinh/appstore-card-transition-demo From the example project, I just changed a bit. In Main.storyboard, ViewController was embed in UINavigationController and UITabbarController. Hope this helps you.
After implementing fix suggested here - 399705d still facing same issue if presenting from CollectionView Cell inside TabBarController. I'm using Xcode 11.3.1, Swift 5.1, iOS 13.3