appssemble / appstore-card-transition

Appstore card animation transition. UICollectionView and UITableView card expand animated transition for iOS
MIT License
583 stars 52 forks source link

Can't use card transition within TabBarController [Not Fixed] #8

Closed tarastomchuk closed 4 years ago

tarastomchuk commented 4 years ago

After implementing fix suggested here - 399705d still facing same issue if presenting from CollectionView Cell inside TabBarController. I'm using Xcode 11.3.1, Swift 5.1, iOS 13.3

image

Abhi-philips commented 4 years ago

Same issue I am also facing with tab bar

fl034 commented 4 years ago

I'm using this workaround

// Somehow the custom modal presentation transitioning uses the tab bar controller so this needs to be done as extension of the Tab Bar Controller.
extension UITabBarController: CardsViewController {
    public var transitionDelegate: CardTransitioningDelegate? {
        // Not needed for now
        get { nil }
        set {}
    }
}
Abhi-philips commented 4 years ago

CardTransitioningDelegate is not there demo project,Could you please tell me where you are using

chelemen-razvan commented 4 years ago

Can you do a demo that reproduces this issue? I seems to work fine for me.

Abhi-philips commented 4 years ago

Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value: file /Users/Project/Pods/appstore-card-transition/AppstoreTransition/AppstoreTransition/PresentCardAnimator.swift, line 90

Abhi-philips commented 4 years ago

app is crashing in PresentCardanimator line number 90 while using tabbar . I am using xcode11.3.1 and swift 5.0

chelemen-razvan commented 4 years ago

I cannot reproduce this. Can you provide a demo project?

quyentrinh commented 4 years ago

Same issue. UITabbarController -> UINavigationControler -> FromViewController(root) -> ToViewController Could not cast value of type 'UITabBarController' to 'AppstoreTransition.CardsViewController'. Screen Shot 2020-03-15 at 3 36 29 PM

chelemen-razvan commented 4 years ago

Guys please provide a demo project if you want this fixed, I cannot produce it.

quyentrinh commented 4 years ago

My demo project. https://github.com/quyentrinh/appstore-card-transition-demo From the example project, I just changed a bit. In Main.storyboard, ViewController was embed in UINavigationController and UITabbarController. Hope this helps you.

chelemen-razvan commented 4 years ago

Fixed in https://github.com/appssemble/appstore-card-transition/releases/tag/1.0.4