appstract / laravel-opcache

Laravel Package for OPcache
MIT License
1.33k stars 118 forks source link

Make URL creation more fault tolerant #109

Closed michalisantoniou6 closed 4 years ago

michalisantoniou6 commented 4 years ago

Hello,

Firstly, thanks for this awesome package!

I experienced a 404 error on a production environment because APP_URL in my .env had a forward slash / at the end of it. As a result, the url was created as "www.example.com//opcache-api", which caused the 404.

I've added trimming to the point where the url is created, which will make this more error proof.

Hopefully you can merge this PR in, if you also think it will benefit users of this package.

Thanks again!

ovanschie commented 4 years ago

Thanks!