document templating (a.k.a. build-args) functionality, from sylabs199

apptainer / apptainer-userdocs

Other

4 stars 25 forks source link

document templating (a.k.a. build-args) functionality, from sylabs199 #250

Closed JasonYangShadow closed 7 months ago

JasonYangShadow commented 7 months ago

This fixes a subpart of https://github.com/apptainer/apptainer-userdocs/issues/239 by merging

https://github.com/sylabs/singularity-userdocs/pull/199 which fixed
https://github.com/sylabs/singularity-userdocs/issues/190

The original PR description was:

Adds a section to the definition_files.rst file, documenting the templating (a.k.a. "build args") functionality.

JasonYangShadow commented 7 months ago

I see that you pretty much took their whole new section without making any changes to what you added in #199. I think that is resulting in some redundancy, especially in the description of the %arguments section in definition_files.rst. Please take another look, remove duplicate information and/or possibly have cross references between the sections.

thanks! I removed examples in the arguments section and created a reference.