apptension / saas-boilerplate

SaaS Boilerplate - Open Source and free SaaS stack that lets you build SaaS products faster in React, Django and AWS. Focus on essential business logic instead of coding repeatable features!
https://apptension.com/saas-boilerplate
MIT License
2.18k stars 253 forks source link

CLI is NOT respecting telemetry opt-out #587

Closed bruteforks closed 3 months ago

bruteforks commented 3 months ago

Describe the bug

exporting SB_TELEMETRY_DISABLED=1 via zshrc and the CLI sends telemetry

SB_TELEMETRY_DISABLED=1 pnpm saas command and the CLI sends telemetry even SB_TELEMETRY_DISABLED=0 pnpm saas still sends telemetry

Steps to reproduce

Add your own honeycomb API key, and watch the telemetry data roll into honeycomb.io

image

image

System Info

no thanks

Logs

No response

Validations

bruteforks commented 3 months ago

Thanks for addressing it! Also https://github.com/apptension/create-saas-boilerplate/ suffers from the same issue.

bruteforks commented 3 months ago

@mkleszcz Have you tested this? It's still not respecting user's preferences.

mkleszcz commented 3 months ago

@bruteforks yes, I have tested it and did it once again now. For me it's working as expected: when there is SB_TELEMETRY_DISABLED env variable set to 1 no data is sent and there is no info about telemetry. Are you sure that you pulled latest changes? If you are using create script this fix will be available on the latest release. Also please do not duplicate issues. For the create script there is a separate repository with separate issues.