search

apptentive / apptentive-android

Apptentive Android SDK
http://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
65 stars 64 forks source link

AND-31 - A large change allows InteractionViews to save instance state, ... #101

Closed skykelsey closed 9 years ago

skykelsey commented 9 years ago

...and use that to track Interaction launch across orientation changes, so that Interaction launch Events are only sent once per real Interaction launch. NavigateToLinkInteraction and AppStoreRatingInteraction are exempt from this. Also fixes an issue where Surveys could be shown again if the screen orientation changed after they were submitted.

msaffitz commented 9 years ago

Working my way through reviewing this. Do you have tests for this?

msaffitz commented 9 years ago

:+1: (but with limited comprehension of the Android lifecycle model)

pkamb commented 9 years ago

Also fixes an issue where Surveys could be shown again if the screen orientation changed after they were submitted.

I'd suggest a separate commit for separate issues such as that.

pkamb commented 9 years ago

:+1: For easier code review I would suggest breaking changes to each interaction, for example, out into its own commit. And then one commit for adding the superclass Interaction invoking of EVENT_NAME_LAUNCH, etc.