apptentive / apptentive-android

Apptentive Android SDK
http://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
65 stars 64 forks source link

engage overload method does not execute callback #141

Closed yloeza closed 6 years ago

yloeza commented 6 years ago

This engage overload method is not properly passing down the BooleanCallback argument, instead is just passing null value as the callback param when executing the static engage event. https://github.com/apptentive/apptentive-android/blob/7dd107ba3fc6813648f2b72c0a57f34bf0cb586d/apptentive/src/main/java/com/apptentive/android/sdk/Apptentive.java#L1145-L1147

Which will make the a call like the following never executes callback onFinish:

Apptentive.engage(context, event, callback);
weeeBox commented 6 years ago

Hey @yloeza,

Sorry for the issue. The fixed 5.0.1 version should be available on Maven in about 1 hour.

Thanks,

-Alex

yloeza commented 6 years ago

Thanks for a quick fix!