search

apptentive / apptentive-android

Apptentive Android SDK
http://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
65 stars 64 forks source link

LogicalOperator Parse errors flood our logs #196

Open sirivanleo opened 4 years ago

sirivanleo commented 4 years ago

We have had this issue for months now. In the past while debugging an issue with the sdk I attached our logger to the ErrorMetrics Listener so we can see apptentive errors in our logging backend but we see many superfluous errors.

https://github.com/apptentive/apptentive-android/blob/a3e4b9f42c51fd64c6c85d1748b6cac975a8c55e/apptentive/src/main/java/com/apptentive/android/sdk/module/engagement/logic/LogicalOperator.java#L27

Mainly the following Apptentive Error Thread java.lang.IllegalArgumentException: No enum constant com.apptentive.android.sdk.module.engagement.logic.LogicalOperator.code_point/local#app#engage_event/invokes/total

When tracing the code I see that it would be more beneficial to treat this like warning or not logException at all. This line point is expected once the client has parsed the server engagement logic and reached the most inner clause. I think I'm going to either filter this error or disable the logger altogether as it hasn't really brought much benefit to our code. I would also like some feedback regarding using the error listener, should I not be using it?

CaseyApptentive commented 4 years ago

Hi @sirivanleo!

Thanks for letting us know. This likely means that the manifest contains invalid values, and we'd like to take a deeper look.

Can you email me at support@apptentive.com and let me know the name of the specific app you're working on? Once we have that we can dive in.

sirivanleo commented 4 years ago

Done

CaseyApptentive commented 4 years ago

Thank you. I saw your message and will coordinate with my colleague to get back to you asap.