search

apptentive / apptentive-android

Apptentive Android SDK
http://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
65 stars 64 forks source link

Hardcoded buttons height causes problems #202

Open ghost opened 4 years ago

ghost commented 4 years ago

We are using your sdk in our app and since we are updating to support CATO (these are specific accessibility rules given to us from our customer) we change our buttons to be minHeight 48dp in theme. Since you have hardcode layout_height set to 36dp, this will result in dialogs text being cut off.

Enjoy Dialog Rate Dialog
dialog1 dialog2

I've found specifically 2 dialogs but they might be more:

I agree that there could be minHeight but I don't understand usage of hardcoded layout_height that restricts height in both dimensions. Would it be possible to update those hardcoded properties to wrap_content?

davros1970 commented 2 years ago

Upvoting this one. Seeing same with 5.8.3 version

CaseyApptentive commented 2 years ago

Thanks for the reports! Looking into this now.

CaseyApptentive commented 2 years ago

Thanks again for the reports, and apologies for the issue. I spoke with my devs and hardcoded button sizes aren't supported on our legacy SDK.

We do have a new Android SDK that's currently in beta, which offers many more options for customizing the look and feel of Apptentive Interactions. Would you be open to trying that?

You can find the latest version, 6.0.2, here.

Then you can find all of the Cookbook for Interface Customizations here.

Let me know if that's helpful.