search

apptentive / apptentive-android

Apptentive Android SDK
http://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
65 stars 64 forks source link

Improvements #51

Closed jacek-marchwicki closed 10 years ago

jacek-marchwicki commented 11 years ago

Hey friends I did some changes in your sdk.

Improvements in .gitignore. Infered some generics to cleanup java warnings. Improved performance in feedback view.

skykelsey commented 11 years ago

Hi @jacek-marchwicki

Sorry it's taken this long to get back to you. Thanks for the effort you have put into this. I'd love to incorporate some of this into the SDK, but there are changes to several parts of the SDK that no longer exist as of 1.0.2, or have been heavily restyled already. For instance, we were previously not specifying styling and letting the default styling determine how the rating flow looked. Now, we have a custom flat UI that is similar to holo, but not exactly the same. The layouts you optimized are probably something I would like to incorporate, but the diffs now are pretty large. The generic classes cleanup, and gradle support will probably be useful as well. The Feedback dialog has now been completely rewritten as the MessageCenterIntroDialog, and a "Thank You" dialog is included with that change.

Before I incorporate any of this (either through a merge or just copying), would you mind signing our contributor agreement? It's just a standard agreement saying you won't claim ownership of the code in the pull request.

https://docs.google.com/a/apptentive.com/spreadsheet/viewform?formkey=dDhMaXJKQnRoX0dRMzZNYnp5bk1Sbmc6MQ#gid=0

If you have any questions or concerns, please email me directly at sky@apptentive.com.

Thanks!

skykelsey commented 10 years ago

Hi Jacek,

I decided this pull request should be closed. There are some good suggestions in here, and some parts that I don't think would be beneficial to include. The parts that are good are not being used anymore. If I end up resurrecting the paper background code, I will make sure to come back and grab the relevant fix from this pull request. Thanks!