search

apptentive / apptentive-android

Apptentive Android SDK
http://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
65 stars 64 forks source link

Fix CLI building. #54

Closed abscondment closed 10 years ago

abscondment commented 10 years ago

Add missing build.xml.

Ignore bin.

skykelsey commented 10 years ago

Hey Brenden,

Sorry to leave you hanging so long. Would you mind filling out our contributor agreement? I will then merge this in.

https://docs.google.com/a/apptentive.com/spreadsheet/viewform?usp=drive_web&formkey=dDhMaXJKQnRoX0dRMzZNYnp5bk1Sbmc6MQ#gid=0

Thanks!

abscondment commented 10 years ago

I'm pretty sure I filled that out right around the time I submitted the pull request. Let me know if I need to do it again.

skykelsey commented 10 years ago

Oops, didn't see that. Thanks!

abscondment commented 10 years ago

No worries :) On Oct 11, 2013 1:30 AM, "Sky Kelsey" notifications@github.com wrote:

Oops, didn't see that. Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/apptentive/apptentive-android/pull/54#issuecomment-26121938 .

skykelsey commented 10 years ago

Hey Brendan,

I've talked this over with some friends, and think that the best course of action is to have the developer generate a new ant build.xml themselves using the android tool. I've pulled in some instructions on how to do that in the README. The problem is that it is up to the developer which version of the SDK to use. I've integrated your .gitignore change that adds bin/ to the ignore list. Please let me know if you feel strongly about build.xml.

skykelsey commented 10 years ago

The integrations are also in a next branch and will be in master this week.

abscondment commented 10 years ago

Cool, thanks.

I'm ambivalent about build.xml - really up to you.

If it were me, I'd add it simply because most 3rd-party libraries I've used do (Facebook, Twitter, mixpanel, GroupMe, etc). It's confusing to be the exception.

One notable library that takes your current approach is ActionBarSherlock, which excludes build.xml and asks developers to run android update project -p . inside the library.

On Thu, Oct 17, 2013 at 2:06 PM, Sky Kelsey notifications@github.com wrote:

The integrations are also in a next branch and will be in master this week.

— Reply to this email directly or view it on GitHub.

skykelsey commented 10 years ago

Yes, that's what I was basing the decision on (and the advice of a couple friends). Another point he brought up was possible conflicts with different operating systems, although I haven't verified they exist.

skykelsey commented 10 years ago

I'll probably revisit this when I switch to supporting Android Studio, which will not happen until it's more widely used.