search

apptentive / apptentive-android

Apptentive Android SDK
http://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
65 stars 64 forks source link

Apptentive crashes if there's nothing entered in a feedback box. #82

Closed gkee42 closed 10 years ago

gkee42 commented 10 years ago

This is a bug in Apptentive for Android v1.4.2.

To reproduce it:

    1. Tap on No button when message "Do you love <MyApp>?" alert appears
    2. Tap on the Send button without input anything

This is the crash log:

05-20 09:14:21.495: E/AndroidRuntime(9692): FATAL EXCEPTION: main 05-20 09:14:21.495: E/AndroidRuntime(9692): java.lang.NullPointerException 05-20 09:14:21.495: E/AndroidRuntime(9692): at com.apptentive.android.sdk.module.engagement.interaction.view.FeedbackDialogInteractionView.sendMessage(FeedbackDialogInteractionView.java:292) 05-20 09:14:21.495: E/AndroidRuntime(9692): at com.apptentive.android.sdk.module.engagement.interaction.view.FeedbackDialogInteractionView.access$400(FeedbackDialogInteractionView.java:34) 05-20 09:14:21.495: E/AndroidRuntime(9692): at com.apptentive.android.sdk.module.engagement.interaction.view.FeedbackDialogInteractionView$5.onClick(FeedbackDialogInteractionView.java:186) 05-20 09:14:21.495: E/AndroidRuntime(9692): at android.view.View.performClick(View.java:4476) 05-20 09:14:21.495: E/AndroidRuntime(9692): at android.view.View$PerformClick.run(View.java:18795) 05-20 09:14:21.495: E/AndroidRuntime(9692): at android.os.Handler.handleCallback(Handler.java:730) 05-20 09:14:21.495: E/AndroidRuntime(9692): at android.os.Handler.dispatchMessage(Handler.java:92) 05-20 09:14:21.495: E/AndroidRuntime(9692): at android.os.Looper.loop(Looper.java:176) 05-20 09:14:21.495: E/AndroidRuntime(9692): at android.app.ActivityThread.main(ActivityThread.java:5493) 05-20 09:14:21.495: E/AndroidRuntime(9692): at java.lang.reflect.Method.invokeNative(Native Method) 05-20 09:14:21.495: E/AndroidRuntime(9692): at java.lang.reflect.Method.invoke(Method.java:525) 05-20 09:14:21.495: E/AndroidRuntime(9692): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1225) 05-20 09:14:21.495: E/AndroidRuntime(9692): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1041) 05-20 09:14:21.495: E/AndroidRuntime(9692): at dalvik.system.NativeStart.main(Native Method)

skykelsey commented 10 years ago

Thanks for reporting this issue. This commit fixes the problem. I will be putting out a new tagged release by next week to address this as well.