apptentive / apptentive-cordova

A plugin for Cordova that lets your app be Apptentive.
https://learn.apptentive.com/knowledge-base/integrating-the-apptentive-cordova-sdk-plugin/
BSD 3-Clause "New" or "Revised" License
3 stars 13 forks source link

PBI-5527: Unify JS files, pass distribution version to native code from there #107

Closed frankus closed 10 months ago

frankus commented 1 year ago

The goal here is to minimize the number of incidental copies of the version information.

The iOS and Android JS files were 99% identical, save for the iOS bridge routing everything through a single "execute" method to be more like the Android bridge.

Instead, this breaks the iOS bridge up into individual methods so that the JS code can be identical between platforms. The iOS code also looks for a distribution version passed in from the JS code.

I also modified the Android code to get the distribution version from the JS code. Note there appears to be a bug where updating the distribution version doesn't take after the initial conversation is created (PBI-5634)