Make writing of log file configurable

apptentive / apptentive-ios

Apptentive Legacy SDK for iOS. See https://github.com/apptentive/apptentive-kit-ios for Version 6.

http://www.apptentive.com/

BSD 3-Clause "New" or "Revised" License

147 stars 103 forks source link

Make writing of log file configurable #292

Closed ghost closed 3 years ago

ghost commented 3 years ago

For us to be able to integrate your SDK in our product we have a 3rd party security requirement that the SDK does not write a debug log file to the Caches directory. In this PR I've made the creation of this log file configurable and left the default behaviour to the existing situation. Hopefully you guys can integrate this one, it would greatly help us. Thanks in advance and don't hesitate to contact me if there's any comments!

Kind regards, Benjamin van den Hout

ghost commented 3 years ago

FYI, I've already submitted my details to the contribution form.

frankus commented 3 years ago

I just merged this to the contributions branch, and it's currently working its way through our internal release process, at which point we will update the master branch with this and a couple of other fixes and create a release/tag.

ghost commented 3 years ago

Brilliant, thanks Frank!

frankus commented 3 years ago

Your contribution is now live in the 5.3.2. release.