search

apptentive / apptentive-ios

Apptentive Legacy SDK for iOS. See https://github.com/apptentive/apptentive-kit-ios for Version 6.
http://www.apptentive.com/
BSD 3-Clause "New" or "Revised" License
147 stars 103 forks source link

Swift compiler error when building Mac Catalyst app with Apptentive Swift package #300

Closed rich-shimano-sap closed 2 years ago

rich-shimano-sap commented 2 years ago

Adding the Apptentive framework via Swift Package Manager to our iOS/Mac Catalyst app causes the following compiler error when building the Mac Catalyst app (the iOS app builds fine) with Xcode 13.2.1+:

...SourcePackages/checkouts/apptentive-kit-ios/Sources/ApptentiveKit/Model/Environment.swift:160:35: error: cannot find type 'CTTelephonyNetworkInfo' in scope

Screen Shot 2022-05-28 at 8 32 05 PM Screen Shot 2022-05-28 at 8 32 18 PM
CaseyApptentive commented 2 years ago

Hi @rich-shimano-sap, happy to help. Which version of the SDK are you using?

We've recently released a new version of our SDK with some big improvements, including support for Swift Package Manager: 6.0.2

Would you be open to using that version if you aren't already?

rich-shimano-sap commented 2 years ago

Sorry I forgot to mention it--we are using 6.0.2 and experiencing the Mac Catalyst build error with that Swift package.

CaseyApptentive commented 2 years ago

Thanks, @rich-shimano-sap. We'll look into this asap and get back to you.

Is this holding up a release?

rich-shimano-sap commented 2 years ago

It is not holding up a release exactly--we would just prefer to use the latest SDK via Swift Package Manager, if possible. Thanks for your help!

CaseyApptentive commented 2 years ago

Thanks for the details! I'll be in touch as soon as I know more from my team.

CaseyApptentive commented 2 years ago

Hi @rich-shimano-sap. My team has made a branch that is available for testing here: apptentive-kit-ios: catalyst

Can you give it a try and let me know the results?

rich-shimano-sap commented 2 years ago

That fix appears to work--both our iOS and Mac Catalyst app appear to build and archive successfully!

CaseyApptentive commented 2 years ago

Thanks for confirming. This was also released in 6.0.3. Let us know if you need anything else.