search

apptentive / apptentive-kit-ios

ApptentiveKit SDK for iOS and iPadOS
https://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Disable gathering carrier info #30

Open andrewjmeier opened 1 year ago

andrewjmeier commented 1 year ago

In the previous version we could set gatherCarrierInfo to false. That feature does not appear to exist in ApptentiveKit. Are there plans to include that soon?

CaseyApptentive commented 1 year ago

Great question @andrewjmeier. Looking into this with my team and will get back to you asap.

CaseyApptentive commented 1 year ago

@andrewjmeier, checked with my team and we do not currently have this ability in the ApptentiveKit SDK. We have it as a work item but it's not yet scheduled. I can keep you updated as we do work on that, though it may not happen this quarter.

Is this an important feature for you and your team? Let me know so we can factor it into our priorities appropriately.

andrewjmeier commented 1 year ago

Thanks for such a quick reply @CaseyApptentive! I expect that feature will block us from being able to update.

We also need to figure out how we're going to migrate from using ApptentiveStyleSheet and the path for that is also not particularly clear.

CaseyApptentive commented 1 year ago

Let me check in with my team about how this fits on our roadmap. I'll follow up as soon as I know more but it may be at least a few days.

Are you currently running an older version of the SDK that does allow for this feature?

andrewjmeier commented 1 year ago

Yes, we're currently using version 5.3.4

CaseyApptentive commented 1 year ago

Thanks @andrewjmeier.

I took a closer look at the backstory here.

Being able to set the gatherCarrierInfo property to false (or NO for Objective-C) on their ApptentiveConfiguration object was introduced in SDK 5.3.4 to free up customers that were seeing a crash due to a bug on Apple's end.

That was a bug that Apple introduced in iOS 14.5.

Since then, this feature has not been widely used -- in fact, I don't recall of hearing of it since 2021. I'd encourage testing and playing it safe, but I believe that this is no longer an issue.

Are you seeing any issues when gatherCarrierInfo is set to true?

andrewjmeier commented 1 year ago

Ok, I don't have the context for why we ended up turning it on. I haven't seen any issues with it set to true, but I've only tried on one device so far.

Our main motivation for keeping it set to false is that we don't want to collect additional user data that we don't need. I wouldn't consider carrierInfo particularly sensitive but if we don't actually need to collect it, why should we?

CaseyApptentive commented 1 year ago

@andrewjmeier thanks for the context. This is a standard piece of information that we typically collect and it does have some built in targeting and reporting functionality around it that can be especially helpful for contacting your customers/understanding any bugs that they might be seeing.

I've let our Product team know about this request but it's likely not very high on our roadmap.

Would you be able to use the new SDK without having this? Let me know so we can prioritize appropriately.