apptentive / apptentive-kit-ios

ApptentiveKit SDK for iOS and iPadOS
https://www.apptentive.com
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Package.swift copy Privacy Manifest Resource file #53

Open FONickReichard opened 5 months ago

FONickReichard commented 5 months ago

Environment Details: Version: 6.5.0 Dependency Management: SPM Relates To: Privacy Manifest (#529) commit: 3daaa1002b2291d992d0f05b19ac1722983690fc

Hello,

Based on the following path structure: Sources/ApptentiveKit/Resources/PrivacyInfo.xcprivacy I am wondering if the PrivacyInfo.xcprivacy file needs to be copied in the Package.swift file.

Ex:

   targets: [
        .target(
            name: "ApptentiveKit",
            dependencies: [],
            exclude: ["Info.plist"],
            resources: [.copy("Resources/SwiftPM.txt"), .copy("Resources/Distribution.plist"), .copy("Resources/PrivacyInfo.xcprivacy")]
        ),

Correct me if I'm wrong, I believe the PrivacyInfo.xcprivacy file should be included in the clients apps' bundle so that the privacy report can be generated after archiving a build.

Any feedback would be great.

Thank you

RamyaSmg34 commented 4 months ago

Hello,

Even I am able to reproduce this issue, without .copy("Resources/PrivacyInfo.xcprivacy") under targets inside Package.swift file, we are not able to generate Privacy report after archiving a build.

Note: Tried by editing Package.swift file locally as below by including .copy("Resources/PrivacyInfo.xcprivacy") and was able to generate Privacy report.

 targets: [
        .target(
            name: "ApptentiveKit",
            dependencies: [],
            exclude: ["Info.plist"],
            resources: [.copy("Resources/SwiftPM.txt"), .copy("Resources/Distribution.plist"), .copy("Resources/PrivacyInfo.xcprivacy")]
        ),

Can you please look into this and help here

Thank you

FONickReichard commented 4 months ago

@frankus Could we get an update on this when you're free. Thanks!

frankus commented 4 months ago

@FONickReichard I'll get this prioritized. We seem to have a bit of a gap in our issue ingestion system where this has gotten lost in the shuffle.

FONickReichard commented 4 months ago

Thank you for the update @frankus

FONickReichard commented 3 months ago

Hey @frankus ,

Friendly check in. Is there an eta for a new version?

Thanks.

frankus commented 3 months ago

Just released as part of the v6.6.0.

(We're aware of an issue with displaying surveys in this release (only) due to an API rollout taking longer than the SDK release. On the off chance you run into it should be fixed within 24 hours).

MichaelWellsSM commented 3 months ago

I believe the same would apply to the podspec... thank you.

einsteinx2 commented 2 months ago

Just released as part of the v6.6.0.

Still broken...

The current Package.swift file has .copy("PrivacyInfo.xcprivacy") instead of .copy("Resources/PrivacyInfo.xcprivacy") so it doesn't get included...

einsteinx2 commented 2 months ago

I believe the same would apply to the podspec... thank you.

That's correct, it's also missing from the podspec, it must be specified as a resource. Specifically it's missing from this line:

spec.resource_bundles = { "ApptentiveKitResources" => [ "Sources/ApptentiveKit/Resources/*.lproj", "Sources/ApptentiveKit/Resources/Media.xcassets", "Sources/ApptentiveKit/Resources/Distribution.plist" ] }

which should be

spec.resource_bundles = { "ApptentiveKitResources" => [ "Sources/ApptentiveKit/Resources/*.lproj", "Sources/ApptentiveKit/Resources/Media.xcassets", "Sources/ApptentiveKit/Resources/Distribution.plist", "Sources/ApptentiveKit/Resources/PrivacyInfo.xcprivacy" ] }