Return subitems in invoices as a map

appuio / appuio-cloud-reporting

Reporting for APPUiO Cloud

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

Closed glrf closed 2 years ago

glrf commented 2 years ago

In https://github.com/appuio/appuio-cloud-reporting/pull/65 it was suggested to switch to a map for subitems in invoices.

This is technically a breaking change, but as we did not have a release since introducing subitems we can ignore this

[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, dependency as they show up in the changelog
[x] Update tests.
[x] Link this PR to related issues.

glrf commented 2 years ago

One drawback I see is that map items are non deterministically ordered. Just something to be aware of.

Postgres did not return the items in a deterministic order anyway (why we sort the slices in the test), so we don't loose much there