Refactoring state management with ngrx/data - Githubissues

appuio / cloud-portal

APPUiO Cloud Portal (Web Frontend)

Apache License 2.0

5 stars 0 forks source link

Refactoring state management with ngrx/data #482

Closed ccremer closed 1 year ago

ccremer commented 1 year ago

Summary

This PR partially replaces internal state management with the @ngrx/data framework. This framework sits on top of ngrx that is already used here, but it abstracts a lot of boilerplate for setting up state management in Angular. ngrx/data re-adds back familiar service classes specifically for REST-y entities, but is backed with state.

Not every Kubernetes entity has been refactored in this PR. Both approaches can co-exist and the "legacy" boilerplate can eventually be replaced with ngrx/data later on.

Known issues:

For now, the Organization, SelfSubjectAccessReview and OrganizationMembers entities have collection services implemented with ngrx/data and each has their own "Data service". Eventually, these data services should be consolidated into one generic Kubernetes data service.
The Teams component has a workaround in place for the initial app load. This should only be necessary as long as we currently haven't migrated Teams module also to ngrx/data. For the user, this shouldn't be noticeable at all (actually, this fixes a bug that is currently in master).

Checklist

[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, as they show up in the changelog
[x] Update tests.
[x] Link this PR to related issues.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-482-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	bbff0fa6b81c5c56425206d3bab2c55593098ca3
Helm release	appuio-control-api-preview/portal-pr-482
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-482-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	ac96b8f45af8a9b8f15c3f4ccd6ec75fd52b4231
Helm release	appuio-control-api-preview/portal-pr-482
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-482-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	cad0b3096c9f6d3b29b933e37928b816adccea67
Helm release	appuio-control-api-preview/portal-pr-482
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-482-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	10be3f839b610e686540afc2f90797c62f992984
Helm release	appuio-control-api-preview/portal-pr-482
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-482-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	f58401b8470503f115ccf2b22fc28a13590ecf1e
Helm release	appuio-control-api-preview/portal-pr-482
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

✔️ Preview deployment uninstalled


Helm release	appuio-control-api-preview/portal-pr-482
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443