Edit members of Billing Entities

ccremer commented 1 year ago

Summary

Part of #438 Allows VSHNeers to edit members (viewer and admin roles) of billing entities. Similar to Teams, the link to edit members is displayed in the Billing Entity list view.

It works by updating the respective BE billingentity-be-####-{admin,viewer} cluster role and -bindings. Currently, the -viewer role and role binding are already created by the control API. However, if the -admin and -viewer roles and -bindings don't yet exist, they will be created. The link to the edit view will be displayed if the user has the update permission on the admin rolebinding. However, when loading the view, the UPDATE permission is also required on the -viewer role binding, and the GET permission for the BE itself.

Checklist

[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, as they show up in the changelog
[x] Update tests.
[x] Link this PR to related issues.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	76c2b8438c565051684bdcf338af7e84909ab932
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	95aff51f484010b2d26681c5a251e596744fa5d8
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	9a4a451f8ed550294e573e8ccfbf561a35ed90c8
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	a88f6f1361e78dc24e0653fc3076792e80a5c84f
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	d0299a312999795624c0e687c7f22f6b4fb33650
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	f97494bc39777bd2ce972e6f06c73ee393619460
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	1b8f7ab964cdeb8c8dca21b3e9488f31fea86bd5
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

ccremer commented 1 year ago

Something does not seem to work. When I try to edit the members of any BillingEntity, I get the error "Billing members could not be loaded." There is also a GlitchTip report that might help.

@corvus-ch I've sent you a DM with the stuff that you need to apply manually first, since the Server side part isn't implemented/ready for this feature yet. Sorry about leaving that out in the PR

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	8daf2f30e9f6184ee14e3996b264747c30601fdc
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	8c5d73795044a967d118a7f0bbc48b8855335361
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active


App URL	https://portal-pr-508-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	0ff7bdc8cc34a846fefb6f8954ff654d9b93f6fe
Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

✔️ Preview deployment uninstalled


Helm release	appuio-control-api-preview/portal-pr-508
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

appuio / cloud-portal