appuio / cloud-portal

APPUiO Cloud Portal (Web Frontend)
Apache License 2.0
5 stars 0 forks source link

Create Billing #525

Closed ccremer closed 1 year ago

ccremer commented 1 year ago

Summary

Closes #522 image

Deployment notice

The ConfigMap config.json must be extended to provide a list of countries that should be selectable in the Billing form. It has the format countries: { code?: string; name: string }[]. For example, the list could look like this:

  "countries": [
    { "name": "Switzerland" }
  ],

(note: the country code isn't technically used yet, but may be of use in the future)

Checklist

ccremer commented 1 year ago

The current country list is the following:

<snippet since irrelevant>

Please let me know if there are countries missing or excess

ccremer commented 1 year ago

@corvus-ch I believe this feature is now ready to be reviewed. Please note that the create permission is required for non-admins, which is currently missing in https://github.com/appuio/control-api/blob/1e86385a9df594547ca95fdeca40a9836f5d0122/config/user-rbac/basic-user-role.yml#L17-L22

ccremer commented 1 year ago

@corvus-ch I forgot to add the legal note. Now it's displayed when creating new billing address, let me know if the note is also required for editing existing billing.

tobru commented 1 year ago

let me know if the note is also required for editing existing billing.

It's only required for registering new billing addresses.

github-actions[bot] commented 1 year ago

🚀 Preview deployment active

App URL https://portal-pr-525-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision a540249e1d6762c88488f1ddb5300b4b7da6f20e
Helm release appuio-control-api-preview/portal-pr-525
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 1 year ago

✔️ Preview deployment uninstalled

Helm release appuio-control-api-preview/portal-pr-525
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443