Closed ccremer closed 1 year ago
The current country list is the following:
<snippet since irrelevant>
Please let me know if there are countries missing or excess
@corvus-ch
I believe this feature is now ready to be reviewed.
Please note that the create
permission is required for non-admins, which is currently missing in https://github.com/appuio/control-api/blob/1e86385a9df594547ca95fdeca40a9836f5d0122/config/user-rbac/basic-user-role.yml#L17-L22
@corvus-ch I forgot to add the legal note. Now it's displayed when creating new billing address, let me know if the note is also required for editing existing billing.
let me know if the note is also required for editing existing billing.
It's only required for registering new billing addresses.
App URL | https://portal-pr-525-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud |
Revision | a540249e1d6762c88488f1ddb5300b4b7da6f20e |
Helm release | appuio-control-api-preview/portal-pr-525 |
Cluster | https://api.cloudscale-lpg-2.appuio.cloud:6443 |
To uninstall this deployment, close or merge this PR.
Helm release | appuio-control-api-preview/portal-pr-525 |
Cluster | https://api.cloudscale-lpg-2.appuio.cloud:6443 |
Summary
Closes #522
Deployment notice
The ConfigMap
config.json
must be extended to provide a list of countries that should be selectable in the Billing form. It has the formatcountries: { code?: string; name: string }[]
. For example, the list could look like this:(note: the country code isn't technically used yet, but may be of use in the future)
Checklist
bug
,enhancement
,documentation
,change
,breaking
, as they show up in the changelog