Use display name as title

appuio / cloud-portal

APPUiO Cloud Portal (Web Frontend)

Apache License 2.0

5 stars 0 forks source link

Use display name as title #555

Closed steffinchen closed 10 months ago

steffinchen commented 11 months ago

Summary

Uses the entity's display name as title and in messages, if the display name is not set, falls back to the entity's name.

Changes

Display name as title for lists, forms, and in messages
Summary cards in the overview list for Billing, Organizations, and Teams now also show the ID (aka metadata.name) as it's not the visual title anymore

Screenshots

Closes https://github.com/appuio/cloud-portal/issues/492

Checklist

[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, as they show up in the changelog
[x] Update tests.
[x] Link this PR to related issues.

steffinchen commented 11 months ago

@corvus-ch Now that the display name is used as visual title, the name (sometimes also called ID) isn't shown anymore when editing an entity (see screenshot). Is it relevant or useful for the user to see it? One possibility would be to add it to the visual title in parentheses (see 2nd screenshot for an example). What do you think?

Display name only:

Display name with ID:

github-actions[bot] commented 11 months ago

🚀 Preview deployment active


App URL	https://portal-pr-555-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	891ab4104b2929669549deaa27aafbcfe37fef3d
Helm release	appuio-control-api-preview/portal-pr-555
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 11 months ago

🚀 Preview deployment active


App URL	https://portal-pr-555-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	fd6461e7f9f8323b4c0b218bfb132984b8782a77
Helm release	appuio-control-api-preview/portal-pr-555
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

steffinchen commented 10 months ago

That, or just keep the ID as title in the edit. My argument: the ID is constant and cannot be changed. The Display name however can be changed. I find it confusing, if I can change something in an input field, but the old value is still visible at another place.

That's a good point. I've changed all the edit form titles, so they show the entity's id.

github-actions[bot] commented 10 months ago

🚀 Preview deployment active


App URL	https://portal-pr-555-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision	de459a1970e86381955511211567076735e949c7
Helm release	appuio-control-api-preview/portal-pr-555
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

github-actions[bot] commented 10 months ago

✔️ Preview deployment uninstalled


Helm release	appuio-control-api-preview/portal-pr-555
Cluster	https://api.cloudscale-lpg-2.appuio.cloud:6443