appuio / component-openshift4-authentication

Commodore component to manage authentication on OpenShift 4
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Allow multiple sudoer groups #70

Closed bastjan closed 2 years ago

bastjan commented 2 years ago

Fixes #62

Adds a list sudoGroups and deprecates the parameter sudoGroupName.

Checklist

bastjan commented 2 years ago

If I wanted to be veery nitpicky: To preserve the exact same behavior as before we would need to remove sudoers from the list if sudoGroupName is set, but I think that's a bit of a pain to implement and might lead to some other edge case weirdness, so I think this solution is good enough.

I though of it but seems to be too much magic 😅