appuio / component-openshift4-ingress

Commodore component to manage Ingress Controllers on OpenShift 4
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Add support for annotations on ingress controllers #15

Closed anothertobi closed 3 years ago

anothertobi commented 3 years ago

Closes #14

Checklist

anothertobi commented 3 years ago

@ccremer this renders the following when no annotations are set:

metadata:
  annotations: {}

Is that OK or could this lead to problems in the ArgoCD sync?

ccremer commented 3 years ago

I'd say that should be ok, as long as no other operator modifies the resource, in which empty properties could get removed.