search

appuio / component-openshift4-nodes

Commodore Component: OpenShift 4 Machine Management
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

GCP Specific Fields Added to ProviderSpec #15

Closed anothertobi closed 2 years ago

anothertobi commented 3 years ago

The component adds provider-specific fields to the providerSpec [1]. These fields seem to be specific to the GCP provider. The parameter instanceType is set as value for machineType but neither of those is present in the vSphere provider. The zone for GCP would be placement:availabilityZone for AWS.

Sample config on AWS: [2] Sample config on GCP: [3]

[1] https://github.com/appuio/component-openshift4-nodes/blob/master/component/main.jsonnet#L43 [2] https://docs.openshift.com/container-platform/4.6/machine_management/creating_machinesets/creating-machineset-aws.html#machineset-yaml-aws_creating-machineset-aws [3] https://docs.openshift.com/container-platform/4.6/machine_management/creating_machinesets/creating-machineset-gcp.html#machineset-yaml-gcp_creating-machineset-gcp

Steps to Reproduce the Problem

  1. Not configure the instanceType parameter for the component
  2. Compile the cluster with commodore
  3. Error that instanceType is missing

Actual Behavior

Fields specific to GCP are added to the ProviderSpec.

Expected Behavior

No provider-specific fields are added to the ProviderSpec.