appuio / component-openshift4-nodes

Commodore Component: OpenShift 4 Machine Management
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Remove hard-limit of maxPods = 110 #37

Closed DebakelOrakel closed 2 years ago

DebakelOrakel commented 2 years ago

While limiting maxPods to 110 is generally a good idea, in some cases setting the maxPods to >110 should be allowed.
Some setups with huge nodes can run into that limit, knowing that this can cause instability, we should be able to adjust this value nevertheless.

Checklist

tobru commented 2 years ago

The PR misses a why. Please document the reasoning behind this change, so that we can refer back to it in the future when we ask ourselves why this was changed. Thanks.

DebakelOrakel commented 2 years ago

The PR misses a why. Please document the reasoning behind this change, so that we can refer back to it in the future when we ask ourselves why this was changed. Thanks.

Added a text to the description.