Add option to configure machine config pools

appuio / component-openshift4-nodes

Commodore Component: OpenShift 4 Machine Management

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Add option to configure machine config pools #50

Closed glrf closed 2 years ago

glrf commented 2 years ago

Checklist

[ ] PR contains a single logical change (to build a better changelog).
[ ] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, dependency as they show up in the changelog.

glrf commented 2 years ago

I will add a how to explaining some of the ways to use machine pool configs and some pitfalls in a separate PR. But I'd like to have a general review of the component first.

Also this change will most likely cause all worker nodes to reboot one after another as OpenShift somehow doesn't understand that the machine config did not actually change. Should we mark this as breaking, as this should be released during a maintenance window?

glrf commented 2 years ago

Did a bunch of refactoring and removed some magic. I hope this is no a bit more readable.

simu commented 2 years ago

Also this change will most likely cause all worker nodes to reboot one after another as OpenShift somehow doesn't understand that the machine config did not actually change. Should we mark this as breaking, as this should be released during a maintenance window?

I think I'm in favor of making this a new major version, to clearly signal that it needs special care (and to ensure Renovate doesn't auto-update the VSHN defaults)